Forem Core

Ben Halpern
Ben Halpern Subscriber

Posted on

Moving billboard event counting into a background job

#performance

For a while we've had billboard data counting done in a hacky synchronous way in the controller itself. This has caused problems, so working on getting these into workers — where they should have been all along.

I have this WIP pull request in motion if you want to follow along. It's just a draft with some stuff to be worked out.

Move billboard calc to worker #21975

benhalpern avatar
benhalpern posted on

What type of PR is this? (check all applicable)

  • [ ] Refactor
  • [ ] Feature
  • [ ] Bug Fix
  • [ ] Optimization
  • [ ] Documentation Update

Description

Related Tickets & Documents

  • Related Issue #
  • Closes #

QA Instructions, Screenshots, Recordings

Please replace this line with instructions on how to test your changes, a note on the devices and browsers this has been tested on, as well as any relevant images for UI changes.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • [ ] Semantic HTML implemented?
  • [ ] Keyboard operability supported?
  • [ ] Checked with axe DevTools and addressed Critical and Serious issues?
  • [ ] Color contrast tested?

For more info, check out the Forem Accessibility Docs.

Added/updated tests?

We encourage you to keep the code coverage percentage at 80% and above.

  • [ ] Yes
  • [ ] No, and this is why: please replace this line with details on why tests have not been included
  • [ ] I need help with writing tests

[optional] Are there any post deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

alt_text

View on GitHub

Top comments (0)